[IMPL] - added support for sass and scss stylesheet languages#4292
Merged
adhami3310 merged 29 commits intoreflex-dev:mainfrom Mar 18, 2025
Merged
[IMPL] - added support for sass and scss stylesheet languages#4292adhami3310 merged 29 commits intoreflex-dev:mainfrom
adhami3310 merged 29 commits intoreflex-dev:mainfrom
Conversation
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
picklelo
reviewed
Nov 4, 2024
adhami3310
reviewed
Nov 7, 2024
adhami3310
requested changes
Nov 7, 2024
Member
adhami3310
left a comment
adhami3310
left a comment
There was a problem hiding this comment.
This looks much better now, a few nitpicks and we should be good to go !
Contributor
Author
|
Sorry, that's why I can't see the error... Unit tests, cp312
Unit tests, cp310
|
Contributor
Author
Units tests
|
Contributor
Author
|
well, for the |
adhami3310
reviewed
Nov 12, 2024
| assert compiler.compile_root_stylesheet(stylesheets) == ( | ||
| str(Path(".web") / "styles" / "styles.css"), | ||
| "@import url('../public/styles.css'); \n", | ||
| "@import url('./styles.css'); \n", |
Member
There was a problem hiding this comment.
are you sure this won't break anything?
Contributor
Author
There was a problem hiding this comment.
I don't know where this could cause a problem, since all the supported stylesheet files in the app/assets directories and subdirectories are copied or compiled and saved in the .web/styles directory and no longer in the .web/public directories.
and also, I checked the second batch of the tests/integration group and the tests/integration/test_tailwind.py (which is the only one to have tests impacted by the changes) passed the tests without any errors, which is why I don't understand the error in the first batch of the tests/integration group.
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
…/KronosDev-Pro/reflex into add-sass-scss-stylesheet-support
adhami3310
approved these changes
Nov 18, 2024
Member
adhami3310
left a comment
adhami3310
left a comment
There was a problem hiding this comment.
this looks good to me, i'm tagging @masenf just to confirm the change from .web/public to .web/styles is a fine one.
bhatia2akshit
pushed a commit
to bhatia2akshit/reflex
that referenced
this pull request
Mar 19, 2025
…-dev#4292) * [IMPL] - added support for sass and scss stylesheet languages - better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file * fix f-string bug * make "libsass" an optional dependency * remove libsass of deps list * revert peotry relock * fix test caused by optional "libsass" deps * improving `_compile_root_stylesheet` function and add folder stylesheets unit test * fix the copy files in assets to public folder * remove useless f-string * little general improvement * fix f-string * remove useless path search * remove unused var & import * [IMPL] - added support for sass and scss stylesheet languages - better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file * fix f-string bug * make "libsass" an optional dependency * remove libsass of deps list * fix test caused by optional "libsass" deps * improving `_compile_root_stylesheet` function and add folder stylesheets unit test * fix the copy files in assets to public folder * remove useless f-string * little general improvement * fix f-string * remove useless path search * remove unused var & import --------- Co-authored-by: Khaleel Al-Adhami <khaleel.aladhami@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
New Feature Submission:
Changes To Core Features: